Tal Nisan has submitted this change and it was merged. Change subject: core: removal of unneeded member/method ......................................................................
core: removal of unneeded member/method StorageDomainCommandBase has a private member called _storagePool and a method called getStoragePool() which overrides the getStoragePool() method (which has the same implementation) defined at AuditLogableBase. The setter method isn't being overriden, which means that calling getStoragePool() on StorageDomainCommandBase and lower classes in it's hierarchy will return the value of the _storagePool member defined in StorageDomainCommandBase, while using the setter will set the value of the storage_pool member defined in AuditLogableBase, thus it won't affect the value of the recieved storage pool. In this patch I just removed the storage_pool member defined within StorageDomainCommandBase as it's unneeded (we already have that higher in the hierarchy) and it's getter as they are unneeded. Change-Id: Ie4746c35e2f5c37e672e47e56314d115c6b25025 Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4746c35e2f5c37e672e47e56314d115c6b25025 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
