Allon Mureinik has uploaded a new change for review. Change subject: core: Remove StoragePoolIsoMapDAO.update impl ......................................................................
core: Remove StoragePoolIsoMapDAO.update impl Since the owner column was removed from StoragePoolIsoMap in the previous patch, it's only (database) mutable column is the status column. In other words, there is no difference between the update and updateStatus methods. This patch removes the Updatestorage_pool_iso_map stored procedure and replaces the implementation of the update method with a delegation to updateStatus. Change-Id: Ia661353ed7b100795d90c9390866c955a1a6290d Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/dbscripts/storages_san_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java 2 files changed, 1 insertion(+), 23 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/14338/1 diff --git a/backend/manager/dbscripts/storages_san_sp.sql b/backend/manager/dbscripts/storages_san_sp.sql index 69e0410..3b00256 100644 --- a/backend/manager/dbscripts/storages_san_sp.sql +++ b/backend/manager/dbscripts/storages_san_sp.sql @@ -222,24 +222,6 @@ -Create or replace FUNCTION Updatestorage_pool_iso_map(v_storage_id UUID, - v_storage_pool_id UUID, - v_status INTEGER) -RETURNS VOID - - --The [storage_pool_iso_map] table doesn't have a timestamp column. Optimistic concurrency logic cannot be generated - AS $procedure$ -BEGIN - UPDATE storage_pool_iso_map - SET status = v_status - WHERE storage_id = v_storage_id and storage_pool_id = v_storage_pool_id; -END; $procedure$ -LANGUAGE plpgsql; - - - - - Create or replace FUNCTION Deletestorage_pool_iso_map(v_storage_id UUID, v_storage_pool_id UUID) RETURNS VOID diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java index 9240359..45462e1 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java @@ -47,11 +47,7 @@ @Override public void update(StoragePoolIsoMap map) { - MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource().addValue("storage_id", - map.getstorage_id()).addValue("storage_pool_id", map.getstorage_pool_id()).addValue("status", - map.getstatus()); - - getCallsHandler().executeModification("Updatestorage_pool_iso_map", parameterSource); + updateStatus(map.getId(), map.getstatus()); } @Override -- To view, visit http://gerrit.ovirt.org/14338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia661353ed7b100795d90c9390866c955a1a6290d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
