Allon Mureinik has posted comments on this change. Change subject: core: Remove StoragePoolIsoMapDAO.update impl ......................................................................
Patch Set 2: @Liron - we need both signatures due to implemented interfaces, compensation mechanisms, etc. Regarding going the other way - it breeds uglier code, since you need to create a new object just to update it. Moreover, I want to actively discourage adding any new fields to this class, since looking forward we're going to refactor it into /dev/null once we get rid of the ISO domain. -- To view, visit http://gerrit.ovirt.org/14338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia661353ed7b100795d90c9390866c955a1a6290d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
