Yair Zaslavsky has posted comments on this change. Change subject: tools: Support for POSIX and GNU long params in engine-manage-domains ......................................................................
Patch Set 2: (2 inline comments) I also believe that the implementation is too generic. I also have for the meanwhile 2 comments, will add more. .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ArgumentParser.java Line 4: Line 5: /** Line 6: * Represents an argument parser Line 7: * Line 8: * @author [email protected] No author, please :) Line 9: */ Line 10: public interface ArgumentParser { Line 11: /** Line 12: * Adds specified option and its requirements to the parser .................................................... File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/cli/LdapProviderParameterValue.java Line 6: * LDAP provider parameter value Line 7: * Line 8: * @author [email protected] Line 9: */ Line 10: public enum LdapProviderParameterValue { Why do we need this enum, and not have a map, or maybe extend LdapProviderType to have string field containing these values? Line 11: /** Line 12: * Microsoft Active Directory Line 13: */ Line 14: AD (LdapProviderType.activeDirectory), -- To view, visit http://gerrit.ovirt.org/13776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c70ace879ad17121c2ed11fce0ffc06612b79fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
