Alon Bar-Lev has posted comments on this change. Change subject: tools: Support for POSIX and GNU long params in engine-manage-domains ......................................................................
Patch Set 2: Hello, > 2) Having an API to easily add command line argument parsing to other Java > utilities in oVirt (and replace current buggy and non standards complying > implementation) This requirement is not unique to ovirt. If you think this implementation is missing out there in the market, you can publish CLI parsing library as standalone library, and then we can decide if we want to use it or not just like every other project. However, if there is a good enough solution out there, I suggest we use it, even if it provides 80% of functionality. Apart from that, as we see in python or in shell, the task of parsing argument is very simple... it cannot be that we invest so many lines of code (~3000) to do this! If you go ahead with own implementation, implementation should be a simple array of metadata similar to python or getopt_long(3). While a simple function fill out another map with (key, value) pair. These two reference (python, getopt_long) implementations are sufficient for 90% of application needs. No need to re-invent the wheel. Thank you! -- To view, visit http://gerrit.ovirt.org/13776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c70ace879ad17121c2ed11fce0ffc06612b79fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
