Martin Peřina has posted comments on this change. Change subject: tools: Support for POSIX and GNU long params in engine-manage-domains ......................................................................
Patch Set 2: Hi Alon, the primary goal is to support POSIX and GNU long parameters in engine-manage-domains. Let's summarize current implementation: 1) Current implementation doesn't follow either POSIX nor GNU long parameters standard 2) Current implementation is split into Java and Shell side => unnecessary code duplication 3) Each oVirt Java command line application has its own independent command line parser implementation 4) Command help is hardcoded in shell script It has been forbidden to me using existing external library, so I have to reinvent the wheel with these features: 1) Argument parser which support POSIX and GNU long parameters syntax and support for sub commands 2) Argument parser provides API to define common options and sub commands with their own options 3) Argument parser is able to generate help using information from defined options and commands 4) Argument parser is written entirely in Java, shell script is used only to start Java applications and forward command line parameters to it 5) Argument parser can be easily used in all other Java command line application in oVirt If you are interested in argument parser details please look at the source code, in my opinion it contains enough comments to understand it. Thanks Martin -- To view, visit http://gerrit.ovirt.org/13776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c70ace879ad17121c2ed11fce0ffc06612b79fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
