Tal Nisan has uploaded a new change for review.

Change subject: findbugs: Fix fingbugs errors in DisksAllocationModel class
......................................................................

findbugs: Fix fingbugs errors in DisksAllocationModel class

Change-Id: Icad3abfd0d1499f7125bafdd30e43aa7ba1216f1
Signed-off-by: Tal Nisan <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/14464/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
index 40c44fb..dc918d7 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
@@ -33,7 +33,7 @@
 
 public class DisksAllocationModel extends EntityModel
 {
-    protected static Constants constants = 
ConstantsManager.getInstance().getConstants();
+    final protected static Constants constants = 
ConstantsManager.getInstance().getConstants();
 
     private final IEventListener quota_storageEventListener = new 
IEventListener() {
         @Override
@@ -167,13 +167,13 @@
 
         if (e.PropertyName.equals("Disks")) //$NON-NLS-1$
         {
-            UpdateStorageDomainsAvailability();
-            UpdateQuotaAvailability();
+            updateStorageDomainsAvailability();
+            updateQuotaAvailability();
             registerToEvents();
         }
     }
 
-    private void UpdateStorageDomainsAvailability()
+    private void updateStorageDomainsAvailability()
     {
         if (disks == null) {
             return;
@@ -215,7 +215,7 @@
         }
     }
 
-    private void UpdateQuotaAvailability() {
+    private void updateQuotaAvailability() {
         if (disks != null) {
             for (DiskModel diskModel : disks) {
                 diskModel.getQuota().setIsAvailable(quotaEnforcementType != 
QuotaEnforcementTypeEnum.DISABLED);


--
To view, visit http://gerrit.ovirt.org/14464
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icad3abfd0d1499f7125bafdd30e43aa7ba1216f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to