Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs errors in DisksAllocationModel class
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
Line 32: import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs;
Line 33:
Line 34: public class DisksAllocationModel extends EntityModel
Line 35: {
Line 36: final protected static Constants constants =
ConstantsManager.getInstance().getConstants();
should be protected static final
Line 37:
Line 38: private final IEventListener quota_storageEventListener = new
IEventListener() {
Line 39: @Override
Line 40: public void eventRaised(Event ev, Object sender, EventArgs
args) {
--
To view, visit http://gerrit.ovirt.org/14464
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icad3abfd0d1499f7125bafdd30e43aa7ba1216f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
