Vojtech Szocs has posted comments on this change. Change subject: webadmin: Fix repeated logins due to UI plugin REST API heartbeat ......................................................................
Patch Set 1: > Shouldn't the timeout be configurable? Good question. Since there's only one REST API session created for all plugins, its timeout should be preferably configured on (WebAdmin) user-level, instead of plugin-api-level. If we wanted to configure it on plugin-api-level, we'd have to compute the maximum requested timeout for all plugins, i.e. max(timeout_values_requested_by_plugins). As for user-level configuration, we can persist the value either locally or via (yet to be written) server-side user preference infrastructure, anyway there should be a way for user to see and change this value (e.g. UI plugins dialog in WebAdmin). What do you think Oved? I think we should implement configurable timeout in a separate patch though, as this patch focuses mainly on fixing known HTTP 'Authorization' header issue. -- To view, visit http://gerrit.ovirt.org/14411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72c2d4952daac4daa17554b7661ed775c72cb97a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
