Vojtech Szocs has posted comments on this change. Change subject: webadmin: Fix repeated logins due to UI plugin REST API heartbeat ......................................................................
Patch Set 1: > I'd make it an engine configuration. Right, it sounds more like engine/plugin-infra config, rather than user/ux preference config. > Oved/Vojtech - we can maybe combine the two approaches: We can have an > engine-level default time-out, and each plug-in can later override this value > within its own configuration. Since there's only one REST API session shared by all plugins, I'd rather not allow plugins to override the default timeout for now. In future, we should revisit REST API integration and perhaps allow one-session-per-plugin, using dedicated (plugin-specific) credentials to create the session, and controlling the timeout per each plugin. > [as mentioned here before - all of this can be done in separate patches; this > patch is merely the solution for the BZs mentioned in the commit comment, > i.e. event flooding and browser pop-ups resulting from the heartbeat > mechanism] Agreed, let's revisit REST API integration later on via separate patches. -- To view, visit http://gerrit.ovirt.org/14411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72c2d4952daac4daa17554b7661ed775c72cb97a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
