Gilad Chaplik has posted comments on this change. Change subject: findbugs: Fix fingbugs error in StorageListModel class ......................................................................
Patch Set 1: I would prefer that you didn't submit this Tal, your patches are separated per class, this causes an unneeded overhead, they should be separated according to the findbug type you're fixing: e.g., all files that contains changing method name to lower case should reside in the same patch and this patch should contain only changes of that sort. please change. -- To view, visit http://gerrit.ovirt.org/14449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb17363d996bfbddd9ffefcfa06de055da00a42b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
