Maor Lipchuk has posted comments on this change. Change subject: findbugs: Fix fingbugs error in StorageListModel class ......................................................................
Patch Set 1: Looks good to me, but someone else must approve IMO the sorting of patches is the authour choice. Some reviewers might not review it if they think it will be hard to review, but I don't think the authour must change the patches while they don't reflect regressions or bugs in the merge process. Perhaps the commit message can be more informal such as : Fix upper case find bugs error in StorageListModel class. -- To view, visit http://gerrit.ovirt.org/14449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb17363d996bfbddd9ffefcfa06de055da00a42b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
