Daniel Erez has posted comments on this change.
Change subject: findbugs: Call to equals compare different types
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
Line 88: String bootStr = str.toString();
Line 89: if (!bootStr.equals("")) { //$NON-NLS-1$
Line 90: return BootSequence.valueOf(bootStr);
Line 91: }
Line 92: return null;
Is it just for replacing the ternary if? why is it better?
Line 93: }
Line 94:
Line 95: public BootSequenceModel()
Line 96: {
--
To view, visit http://gerrit.ovirt.org/14499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia35fdbd31536ce983f23cd251baf4d4a4e46ee21
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
