Gilad Chaplik has posted comments on this change.
Change subject: findbugs: Call to equals compare different types
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
Line 84: str.append(bs.toString());
Line 85: }
Line 86: }
Line 87:
Line 88: return !str.toString().equals("") ?
BootSequence.valueOf(str.toString()) : null; //$NON-NLS-1$
Shahar, the entire method needs to be ref-actored. the code is unreadable.
sorry that you didn't understand it in the first review :/ I wasn't clear
enough.
but it can be done in a separate patch.
Line 89: }
Line 90:
Line 91: public BootSequenceModel()
Line 92: {
--
To view, visit http://gerrit.ovirt.org/14499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia35fdbd31536ce983f23cd251baf4d4a4e46ee21
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
