Tal Nisan has posted comments on this change.

Change subject: findbugs: Fix fingbugs error in frontend backup models
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
Line 452:                             for (Object item : 
vmBackupModel.getSelectedItems()) {
Line 453:                                 VM vm = (VM) item;
Line 454:                                 if (retVals.get(counter) != null
Line 455:                                         && 
retVals.get(counter).getCanDoAction()) {
Line 456:                                     if (toShowConfirmWindow) {
Instead of using another boolean to see if the loop was already run once I am 
utilizing the one already exists
Line 457:                                         importedVmsBuilder.append(", 
"); //$NON-NLS-1$
Line 458:                                     }
Line 459: 
Line 460:                                     
importedVmsBuilder.append(vm.getName());


--
To view, visit http://gerrit.ovirt.org/14452
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74d71e32a52bd41bba78099401b4dfee79330aaa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to