Maor Lipchuk has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in frontend backup models
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
Line 237: for (Object a :
templateBackupModel.getSelectedItems())
Line 238: {
Line 239: VmTemplate template = (VmTemplate) a;
Line 240: if (retVals.get(counter) != null &&
retVals.get(counter).getCanDoAction()) {
Line 241: if (toShowConfirmWindow) {
What this toShowConfirmWindow is used for?
Why not using org.apache.commons.lang.StringUtils.join for array list instead
playing with the StringBuilder every time
Line 242:
importedTemplatesBuilder.append(", "); //$NON-NLS-1$
Line 243: }
Line 244:
Line 245:
importedTemplatesBuilder.append(template.getName());
--
To view, visit http://gerrit.ovirt.org/14452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74d71e32a52bd41bba78099401b4dfee79330aaa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
