Asaf Shakarchi has uploaded a new change for review.

Change subject: build: Consolidate static plugins version into properties.
......................................................................

build: Consolidate static plugins version into properties.

Consolidation of all plugin versions written explicitly everywhere
into properties of the root pom.

Change-Id: Ic7dacb9641e0716538b60bb5f22a832f3c462de6
Signed-off-by: Asaf Shakarchi <[email protected]>
---
M pom.xml
1 file changed, 28 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/14556/1

diff --git a/pom.xml b/pom.xml
index 4b0806d..6522141 100644
--- a/pom.xml
+++ b/pom.xml
@@ -95,6 +95,20 @@
     <maven-resources-plugin.version>2.4.3</maven-resources-plugin.version>
     <exec-maven-plugin.version>1.2</exec-maven-plugin.version>
     <maven-ejb-plugin.version>2.3</maven-ejb-plugin.version>
+       <maven-source-plugin.version>2.1.2</maven-source-plugin.version>
+       
<eclipse-lifecycle-mapping-plugin.version>1.0.0</eclipse-lifecycle-mapping-plugin.version>
+       <maven-checkstyle-plugin.version>2.9.1</maven-checkstyle-plugin.version>
+       <maven-compiler-plugin.version>2.3.2</maven-compiler-plugin.version>
+       <taglist-maven-plugin.version>2.4</taglist-maven-plugin.version>
+       
<build-helper-maven-plugin.version>1.4</build-helper-maven-plugin.version>
+       <maven-jar-plugin.version>2.2</maven-jar-plugin.version>
+       <gwt-maven-plugin.version>2.3.0</gwt-maven-plugin.version>
+       <maven-antrun-plugin.version>1.7</maven-antrun-plugin.version>
+       <maven-ear-plugin.version>2.8</maven-ear-plugin.version>
+       <maven-war-plugin.version>2.2</maven-war-plugin.version>
+       
<jboss-modules-maven-plugin.version>1.0-SNAPSHOT</jboss-modules-maven-plugin.version>
+       
<animal-sniffer-maven-plugin.version>1.9</animal-sniffer-maven-plugin.version>
+       
<animal.sniffer.signature-plugin.version>1.0</animal.sniffer.signature-plugin.version>
   </properties>
   <dependencyManagement>
     <dependencies>
@@ -380,7 +394,7 @@
       <plugins>
         <plugin>
           <artifactId>maven-compiler-plugin</artifactId>
-          <version>2.3.2</version>
+          <version>${maven-compiler-plugin.version}</version>
           <configuration>
             <source>${maven.compiler.source}</source>
             <target>${maven.compiler.target}</target>
@@ -393,7 +407,7 @@
         </plugin>
         <plugin>
           <artifactId>maven-checkstyle-plugin</artifactId>
-          <version>2.9.1</version>
+          <version>${maven-checkstyle-plugin.version}</version>
           <dependencies>
             <dependency>
               <groupId>org.ovirt.engine</groupId>
@@ -423,7 +437,7 @@
         </plugin>
         <plugin>
           <artifactId>maven-source-plugin</artifactId>
-          <version>2.1.2</version>
+          <version>${maven-source-plugin.version}</version>
         </plugin>
         <plugin>
           <artifactId>maven-ejb-plugin</artifactId>
@@ -466,7 +480,7 @@
         <plugin>
             <groupId>org.eclipse.m2e</groupId>
             <artifactId>lifecycle-mapping</artifactId>
-            <version>1.0.0</version>
+            <version>${eclipse-lifecycle-mapping-plugin.version}</version>
             <configuration>
                 <lifecycleMappingMetadata>
                     <pluginExecutions>
@@ -490,18 +504,18 @@
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>taglist-maven-plugin</artifactId>
-          <version>2.4</version>
+          <version>${taglist-maven-plugin.version}</version>
         </plugin>
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>build-helper-maven-plugin</artifactId>
-          <version>1.4</version>
+          <version>${build-helper-maven-plugin.version}</version>
         </plugin>
         <!-- Create a test jar, so other modules can depend on the test 
utilities -->
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-jar-plugin</artifactId>
-          <version>2.2</version>
+          <version>${maven-jar-plugin.version}</version>
           <executions>
             <execution>
               <goals>
@@ -513,19 +527,19 @@
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>gwt-maven-plugin</artifactId>
-          <version>2.3.0</version>
+          <version>${gwt-maven-plugin.version}</version>
         </plugin>
 
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-antrun-plugin</artifactId>
-          <version>1.7</version>
+          <version>${maven-antrun-plugin.version}</version>
         </plugin>
 
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-ear-plugin</artifactId>
-          <version>2.8</version>
+          <version>${maven-ear-plugin.version}</version>
           <configuration>
             <fileNameMapping>no-version</fileNameMapping>
           </configuration>
@@ -534,7 +548,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-war-plugin</artifactId>
-          <version>2.2</version>
+          <version>${maven-war-plugin.version}</version>
           <configuration>
             
<outputFileNameMapping>@{artifactId}@.@{extension}@</outputFileNameMapping>
           </configuration>
@@ -546,7 +560,7 @@
         <plugin>
           <groupId>org.ovirt.engine</groupId>
           <artifactId>jboss-modules-maven-plugin</artifactId>
-          <version>1.0-SNAPSHOT</version>
+          <version>${jboss-modules-maven-plugin.version}</version>
           <executions>
             <execution>
               <phase>package</phase>
@@ -563,12 +577,12 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>animal-sniffer-maven-plugin</artifactId>
-        <version>1.9</version>
+        <version>${animal-sniffer-maven-plugin.version}</version>
         <configuration>
           <signature>
             <groupId>org.codehaus.mojo.signature</groupId>
             <artifactId>${animal.sniffer.signature}</artifactId>
-            <version>1.0</version>
+            <version>${animal.sniffer.signature-plugin.version}</version>
           </signature>
           <ignores>
             <ignore>sun.security.krb5.Config</ignore>


--
To view, visit http://gerrit.ovirt.org/14556
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7dacb9641e0716538b60bb5f22a832f3c462de6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to