Michael Pasternak has posted comments on this change.
Change subject: restapi : HTTP Status 500 -
java.lang.NullPointerException(#961046)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
Line 57:
getNetworkClusterDAO().setNetworkExclusivelyAsMigration(getVdsGroupId(),
getNetwork().getId());
Line 58: }
Line 59: NetworkClusterHelper.setStatus(getVdsGroupId(), getNetwork());
Line 60: setSucceeded(true);
Line 61: setActionReturnValue(getNetwork().getId());
does attached network has same id as the original one? iirc new NetworkCluster
is created upon attach
Line 62: }
Line 63:
Line 64: @Override
Line 65: protected boolean canDoAction() {
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 948: request:
Line 949: body:
Line 950: parameterType: Action
Line 951: signatures:
Line 952: - mandatoryArguments: {action.cluster.id|name: 'xs:string',
action.storage_domain.id|name: 'xs:string'}
why you making storage_domain mandatory? - doing this will break api,
import() has default logic when no SD specified
Line 953: optionalArguments: {action.clone: 'xs:boolen',
action.exclusive: 'xs:boolen', action.template.name: 'xs:string',
action.vm.disks.disk--COLLECTION: {disk.id: 'xs:string'}}
Line 954: urlparams: {}
Line 955: headers:
Line 956: Content-Type: {value: application/xml|json, required: true}
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java
Line 38: }
Line 39:
Line 40: @Override
Line 41: public Response doImport(Action action) {
Line 42: validateParameters(action, "cluster.id|name",
"storageDomain.id|name");
why you making storage_domain mandatory? - doing this will break api,
import() has default logic when no SD specified.
Line 43:
Line 44: Guid destStorageDomainId = getDestStorageDomainId(action);
Line 45:
Line 46: ImportVmTemplateParameters params = new
ImportVmTemplateParameters(parent.getDataCenterId(destStorageDomainId),
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
Line 37: }
Line 38:
Line 39: @Override
Line 40: public Response doImport(Action action) {
Line 41: validateParameters(action, "cluster.id|name",
"storageDomain.id|name");
why you making storage_domain mandatory? - doing this will break api,
import() has default logic when no SD specified
Line 42:
Line 43: Guid destStorageDomainId = getDestStorageDomainId(action);
Line 44:
Line 45: ImportVmParameters params = new ImportVmParameters(getEntity(),
--
To view, visit http://gerrit.ovirt.org/14598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0102d1d36de7012ebd98c53ef8eb106ac7b04b7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
