Moti Asayag has posted comments on this change.
Change subject: restapi : HTTP Status 500 -
java.lang.NullPointerException(#961046)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
Line 57:
getNetworkClusterDAO().setNetworkExclusivelyAsMigration(getVdsGroupId(),
getNetwork().getId());
Line 58: }
Line 59: NetworkClusterHelper.setStatus(getVdsGroupId(), getNetwork());
Line 60: setSucceeded(true);
Line 61: setActionReturnValue(getNetwork().getId());
The Network entity isn't changed. However the NetworkCluster ID might be
changed (in case using the command for attaching new network to the cluster, as
it is also can be used for updating the network cluster).
The NetworkCluster is stored internally in the Network element, therefore
fetching the network under the cluster is done by GetAllNetworksByClusterId,
with the network-id and the cluster-id and not by the NetworkCluster id.
Line 62: }
Line 63:
Line 64: @Override
Line 65: protected boolean canDoAction() {
--
To view, visit http://gerrit.ovirt.org/14598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0102d1d36de7012ebd98c53ef8eb106ac7b04b7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
