Gilad Chaplik has posted comments on this change.

Change subject: bll: rename methods to begin with lowercase letter
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 116:         }
Line 117:     }
Line 118: 
Line 119:     @OnTimerMethodAnnotation("_cacheTimer_Elapsed")
Line 120:     public void _cacheTimer_Elapsed() {
not in the scope on this patch
Line 121:         removeClearedAndOldTasks();
Line 122:     }
Line 123: 
Line 124:     /**


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java
Line 31:         String cronExpression = String.format("%d %d %d * * ?", 
calendar.get(Calendar.SECOND),
Line 32:                 calendar.get(Calendar.MINUTE), 
calendar.get(Calendar.HOUR_OF_DAY));
Line 33: 
Line 34:         log.info("Setting audit cleanup manager to run at: " + 
cronExpression);
Line 35:         SchedulerUtilQuartzImpl.getInstance().scheduleACronJob(this, 
"OnTimer", new Class[] {}, new Object[] {},
Done
Line 36:                 cronExpression);
Line 37:         log.info("Finished initializing " + 
getClass().getSimpleName());
Line 38:     }
Line 39: 


--
To view, visit http://gerrit.ovirt.org/14646
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib61e684bcc7f2fcc4fcf38759b7a1648676ad259
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to