Omer Frenkel has posted comments on this change.
Change subject: bll: rename methods to begin with lowercase letter
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 116: }
Line 117: }
Line 118:
Line 119: @OnTimerMethodAnnotation("_cacheTimer_Elapsed")
Line 120: public void _cacheTimer_Elapsed() {
where did you define the scope of this patch?
you're doing great cleanup, why not include this as well?
Line 121: removeClearedAndOldTasks();
Line 122: }
Line 123:
Line 124: /**
--
To view, visit http://gerrit.ovirt.org/14646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib61e684bcc7f2fcc4fcf38759b7a1648676ad259
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
