Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-cleanup-2: backup DB before removing
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-remove/db/clear.py
Line 41: def __init__(self, context):
Line 42: super(Plugin, self).__init__(context=context)
Line 43: self._backupFile = None
Line 44:
Line 45: def _pgpass(self):
We need to move the pgpass creation to common, I guess.
Line 46: fd, pgpass = tempfile.mkstemp(
Line 47: prefix='pgpass',
Line 48: suffix='.tmp',
Line 49: )
Line 65: self.environment[
Line 66: osetupcons.DBEnv.PGPASS_FILE
Line 67: ] = pgpass
Line 68:
Line 69: def _backupDB(self):
We need to move the backup to database ovirt_engine_setup.database.OvirtUtils
instead of having this twice.
Line 70: self._backupFile = os.path.join(
Line 71: osetupcons.FileLocations.OVIRT_ENGINE_DB_BACKUP_DIR,
Line 72: 'engine-cleaned-%s.sql' % (
Line 73: datetime.datetime.now().strftime('%Y%m%d%H%M%S')
--
To view, visit http://gerrit.ovirt.org/14703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89635b7bf6e86fb3bf3657717a903b1efb127b9a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
