Alon Bar-Lev has posted comments on this change. Change subject: packaging: engine-cleanup-2: backup DB before removing ......................................................................
Patch Set 5: (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-05-13 11:37:47 +0200 Line 4: Commit: Sandro Bonazzola <[email protected]> Line 5: CommitDate: 2013-05-14 11:42:02 +0200 Line 6: Line 7: packaging: engine-cleanup-2: backup DB before removing Not that it is that important but all these should go into packaging: setup: as cleanup, setup, upgrade are all setup component. Line 8: Line 9: - Refactored db/schema and db/connectoin plugins Line 10: extracting the pgpass creation in a separate plugin Line 11: moving the pgpass file creation from misc stage to validation stage. .................................................... File packaging/setup/plugins/ovirt-engine-common/db/backup.py Line 100: if ( Line 101: osetupcons.DBEnv.REMOVE_EMPTY_DATABASE in self.environment and Line 102: self.environment[osetupcons.DBEnv.REMOVE_EMPTY_DATABASE] Line 103: ): Line 104: prefix = 'engine-cleaned' I don't think we should have different prefix for backups. And if we do, please put the prefix in environment so it can be set explicitly. Line 105: fd, self.environment[ Line 106: osetupcons.DBEnv.DB_BACKUP_FILE Line 107: ] = tempfile.mkstemp( Line 108: prefix='%s-%s.' % ( .................................................... File packaging/setup/plugins/ovirt-engine-common/db/pgpass.py Line 38: def __init__(self, context): Line 39: super(Plugin, self).__init__(context=context) Line 40: Line 41: @plugin.event( Line 42: stage=plugin.Stages.STAGE_VALIDATION, are you sure this can be moved to validation from misc? Line 43: name=osetupcons.Stages.DB_PG_PASS, Line 44: condition=lambda self: self.environment[ Line 45: osetupcons.DBEnv.PASSWORD Line 46: ] is not None, -- To view, visit http://gerrit.ovirt.org/14703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89635b7bf6e86fb3bf3657717a903b1efb127b9a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
