Alon Bar-Lev has posted comments on this change. Change subject: packaging: Validating DB encoding during setup and upgrade ......................................................................
Patch Set 10: (2 inline comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/db/connection.py Line 77: """, Line 78: ownConnection=True, Line 79: transaction=False, Line 80: )[0]['server_encoding'] Line 81: if encoding.lower() is not 'utf8': should be != and also in the legacy setup... Line 82: self.logger.debug( Line 83: 'Default encoding is not UTF8' Line 84: ) Line 85: raise RuntimeError( Line 78: ownConnection=True, Line 79: transaction=False, Line 80: )[0]['server_encoding'] Line 81: if encoding.lower() is not 'utf8': Line 82: self.logger.debug( I don't think there is a need for this debug message as we do see the above select and the result in the log, and we do see the exception in the log. Line 83: 'Default encoding is not UTF8' Line 84: ) Line 85: raise RuntimeError( Line 86: _( -- To view, visit http://gerrit.ovirt.org/14615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I583b115cf60142cafc5ba66b0dc22e92b4807c84 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
