Alex Lourie has posted comments on this change.

Change subject: packaging: Validating DB encoding during setup
......................................................................


Patch Set 11: (2 inline comments)

....................................................
File packaging/fedora/setup/common_utils.py
Line 1074: 
Line 1075: def checkDbEncoding(dbAdminUser, dbHost, dbPort, dbName):
Line 1076:     """ checkDbEncoding checks DB default encoding on DB server"""
Line 1077: 
Line 1078:     logging.info("Checking encoding of the database 
'ovirt_engine_test' on remote server.")
Done
Line 1079:     out, rc = execRemoteSqlCommand(
Line 1080:         userName=dbAdminUser,
Line 1081:         dbHost=dbHost,
Line 1082:         dbPort=dbPort,


Line 1096:         msg = (
Line 1097:             "\nDatabase '%s' has an incorrect encoding "
Line 1098:             "on a server '%s'. '%s' database should have an UTF8 "
Line 1099:             "encoding. Please fix the DB encoding "
Line 1100:             "before you continue\n" % (dbName, out, dbHost, dbName)
message updated.
Line 1101:         )
Line 1102:         logging.info(msg)
Line 1103:         raise Exception(msg)
Line 1104:     else:


--
To view, visit http://gerrit.ovirt.org/14615
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I583b115cf60142cafc5ba66b0dc22e92b4807c84
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to