Tal Nisan has posted comments on this change.
Change subject: core: Check all attached VMs when updating shared disk boot flag
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 273: boolean vmsContainBootDisk = false;
Line 274: StringBuilder vmsContainingBootDisk = new StringBuilder();
Line 275:
Line 276: for (VM vm : vms) {
Line 277: VmHandler.updateDisksForVm(vm,
getOtherVmDisks(vm.getId()));
1. good point, I will look into it
Line 278: for (Disk disk : vm.getDiskMap().values()) {
Line 279: if (disk.isBoot()) {
Line 280: if (vmsContainBootDisk) { // In case this is not
the first VM to fail, add delimiter
Line 281: vmsContainingBootDisk.append(", ");
--
To view, visit http://gerrit.ovirt.org/14709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ee07e02e08d60f559017d9f8205ab7df41c5c3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
