Vered Volansky has posted comments on this change. Change subject: core: Check all attached VMs when updating shared disk boot flag ......................................................................
Patch Set 2: (3 inline comments) .................................................... Commit Message Line 4: Commit: Tal Nisan <[email protected]> Line 5: CommitDate: 2013-05-13 15:25:49 +0300 Line 6: Line 7: core: Check all attached VMs when updating shared disk boot flag Line 8: The following is one very very very long sentence, this is practically unreadable. Line 9: When updating a VM disk to be bootable, the other VMs that the disk is Line 10: attached to was checked to see if they already have a bootable disk Line 11: attached and if so the operation would have fail giving an error message Line 12: that the VM already has a bootable disk attached, this check was changed to Line 6: Line 7: core: Check all attached VMs when updating shared disk boot flag Line 8: Line 9: When updating a VM disk to be bootable, the other VMs that the disk is Line 10: attached to was checked to see if they already have a bootable disk s/was/were Line 11: attached and if so the operation would have fail giving an error message Line 12: that the VM already has a bootable disk attached, this check was changed to Line 13: check all VMs and after iterating on all if one or more contained a bootable Line 14: disk fail and give an error message containing all of the VMs that the operation Line 7: core: Check all attached VMs when updating shared disk boot flag Line 8: Line 9: When updating a VM disk to be bootable, the other VMs that the disk is Line 10: attached to was checked to see if they already have a bootable disk Line 11: attached and if so the operation would have fail giving an error message s/fail/failed Line 12: that the VM already has a bootable disk attached, this check was changed to Line 13: check all VMs and after iterating on all if one or more contained a bootable Line 14: disk fail and give an error message containing all of the VMs that the operation Line 15: failed on -- To view, visit http://gerrit.ovirt.org/14709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82ee07e02e08d60f559017d9f8205ab7df41c5c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
