Alexander Wels has uploaded a new change for review. Change subject: webadmin: show subtab after reveal ......................................................................
webadmin: show subtab after reveal - Fixed showing the subtab before the reveal happened. This caused previous subtabs to flicker an old subtab when on a different subtab. Change-Id: Ifafcc372e9b8e71c89bd1b7ed80cf4c40f828569 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=916207 Signed-off-by: Alexander Wels <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/14820/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java index 5526e8e..66179d0 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java @@ -58,13 +58,13 @@ } protected void onSelection() { - // Update the layout - updateLayout(); // Reveal the appropriate place based on selection if (hasSelection()) { placeManager.revealPlace(getSubTabRequest()); } else { + // Update the layout + updateLayout(); placeManager.revealPlace(getMainTabRequest()); } } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java index 9894579..ffb25e9 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java @@ -30,6 +30,7 @@ @Override protected void revealInParent() { RevealContentEvent.fire(this, MainContentPresenter.TYPE_SetSubTabPanelContent, this); + UpdateMainContentLayoutEvent.fire(this, true); } } -- To view, visit http://gerrit.ovirt.org/14820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifafcc372e9b8e71c89bd1b7ed80cf4c40f828569 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
