Vojtech Szocs has posted comments on this change. Change subject: webadmin: show subtab after reveal ......................................................................
Patch Set 2: Looks good to me, but someone else must approve Nice patch, I really like the solution where sub-tab panel presenter onReveal() takes care of showing the sub-tab panel UI. Some very minor comments: * in AbstractMainTabWithDetailsPresenter.onSelection() before "placeManager.revealPlace(getSubTabRequest());" line, can you please add a comment like: // Sub tab panel is shown upon revealing the sub tab * in AbstractMainTabWithDetailsPresenter.onSelection() before "setSubTabPanelVisible(false);" line, you can be more specific in the comment, like: // Hide sub tab panel when there is nothing selected * in AbstractSubTabPanelPresenter.onReveal() before "UpdateMainContentLayoutEvent.fire(this, true);" line, can you please add a comment like: // Show sub tab panel when revealing sub tab presenter Otherwise the patch looks good! -- To view, visit http://gerrit.ovirt.org/14820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafcc372e9b8e71c89bd1b7ed80cf4c40f828569 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
