Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: fix otopi implementation version locking
handling
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-remove/files/simple.py
Line 65: def _cleanLines(self, filename, remove_lines):
Line 66: new_content = []
Line 67: with open(filename, 'r') as f:
Line 68: old_content = f.read().splitlines()
Line 69: for line in old_content:
I don't think this should be indented.
Line 70: if line not in remove_lines:
Line 71: new_content.append(line)
Line 72: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append(
Line 73: filetransaction.FileTransaction(
....................................................
File packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py
Line 50: osetupcons.CoreEnv.LINES_GROUP_PREFIX + group
Line 51: ] = {
Line 52: 'name': filename,
Line 53: 'lines': lines,
Line 54: }
I would like to be able to execute this multiple files.
Well, we should also modify the above...
Something like:
self.environment.setdefault(xxx, []).extend(fileList)
self.environment.setdefault(xxx, {}).setdefault(filename, []).extend(lines)
?
Line 55:
Line 56:
Line 57: @util.export
Line 58: class Plugin(plugin.PluginBase):
Line 113: )
Line 114: config.set(
Line 115: section,
Line 116: prefix + '.content',
Line 117: content,
Don't we need single entry per line?
Line 118: )
Line 119:
Line 120: _addFiles(
Line 121: osetupcons.Const.FILE_GROUP_SECTION_PREFIX + 'core',
--
To view, visit http://gerrit.ovirt.org/14700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1b9142088cfa7def37f6d1ad3d2a4204aebe8ae
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
