Shahar Havivi has uploaded a new change for review. Change subject: findbugs: reference comparison of const value instead of long value ......................................................................
findbugs: reference comparison of const value instead of long value findbugs reason: RC: Suspicious reference comparison to constant (RC_REF_COMPARISON_BAD_PRACTICE) Change-Id: I3d1fbe7507f01dbeac13413ff7ed3d957e5380a4 Signed-off-by: Shahar Havivi <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaUtilizationStatusColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/14903/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaUtilizationStatusColumn.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaUtilizationStatusColumn.java index 372de21..f625ac9 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaUtilizationStatusColumn.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaUtilizationStatusColumn.java @@ -34,7 +34,7 @@ if (quota.getStorageSizeGB() == null) { return false; } - return quota.getStorageSizeGB() != QuotaStorage.UNLIMITED + return quota.getStorageSizeGB().longValue() != QuotaStorage.UNLIMITED.longValue() && quota.getStorageSizeGB() < quota.getStorageSizeGBUsage(); } -- To view, visit http://gerrit.ovirt.org/14903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d1fbe7507f01dbeac13413ff7ed3d957e5380a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
