Gilad Chaplik has posted comments on this change.
Change subject: findbugs: reference comparison of const value instead of long
value
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaUtilizationStatusColumn.java
Line 33: private boolean getQuotaExceeded(QuotaStorage quota) {
Line 34: if (quota.getStorageSizeGB() == null) {
Line 35: return false;
Line 36: }
Line 37: return quota.getStorageSizeGB().longValue() !=
QuotaStorage.UNLIMITED.longValue()
missed that.
Line 38: && quota.getStorageSizeGB() <
quota.getStorageSizeGBUsage();
Line 39: }
Line 40:
Line 41: private boolean getQuotaExceeded(QuotaVdsGroup quota) {
--
To view, visit http://gerrit.ovirt.org/14903
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d1fbe7507f01dbeac13413ff7ed3d957e5380a4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
