Yair Zaslavsky has posted comments on this change. Change subject: engine : Fix variable names in VdcReturnValueBase ......................................................................
Patch Set 1: (1 inline comment) Hi, I also see the following pattern - .getVdsmTaskIdList().addAll(createTask...) does createTask return vdsmTaskId? I tried following the code , and from what I see - in the end the task is created at AsyncTaskFactory.Construct- but at this point, it's prior to obtaining a vdsm task id. Also, can you provide the commit hash you rebased againt? I have a patch I would like to put on top of this . .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java Line 90: vdsReturnValue.getCreationInfo(), Line 91: getParameters().getParentCommand(), Line 92: VdcObjectType.Storage, Line 93: getParameters().getStorageDomainId())); Line 94: getReturnValue().getInternalVdsmTaskIdList().add(getParameters().getTaskIds().get(0)); don't you find getTaskIds to still be a bit confusing? task id is vdsm task id or db task id? ;) Line 95: Line 96: return true; Line 97: } Line 98: -- To view, visit http://gerrit.ovirt.org/14909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebfbd19f8eeef4a9a0d30eadaacb1d833cae0ec7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
