Yair Zaslavsky has posted comments on this change.
Change subject: engine : Fix variable names in VdcReturnValueBase
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1484: protected void startPollingAsyncTasks() {
Line 1485: startPollingAsyncTasks(getReturnValue().getVdsmTaskIdList());
Line 1486: }
Line 1487:
Line 1488: protected ArrayList<Guid> getTaskIdList() {
Bare in mind that this is another example on how the names are misleading.
If we deal here with vdsm tasks ids - let's make sure and change the method
name accordingly.
What do you think?
Line 1489: return getParameters().getParentCommand() !=
VdcActionType.Unknown ? getReturnValue().getInternalVdsmTaskIdList()
Line 1490: : getReturnValue().getVdsmTaskIdList();
Line 1491: }
Line 1492:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase.java
Line 16: private boolean succeeded;
Line 17: private boolean isSyncronious;
Line 18: private Object returnValue;
Line 19: private String description = "";
Line 20: private ArrayList<Guid> asyncTaskIdList = new ArrayList<Guid>();
worth considering changing this to dbAsyncTaskIDList? what do u think?
Line 21: private ArrayList<Guid> vdsmTaskIdList = new ArrayList<Guid>();
Line 22: private final ArrayList<Guid> internalVdsmIdList = new
ArrayList<Guid>();
Line 23: private boolean endActionTryAgain = true;
Line 24: private final ArrayList<String> executeFailedMessages = new
ArrayList<String>();
--
To view, visit http://gerrit.ovirt.org/14909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfbd19f8eeef4a9a0d30eadaacb1d833cae0ec7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
