Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: allow interactive PKI cleanup ......................................................................
Patch Set 4: (2 inline comments) .................................................... File packaging/setup/plugins/ovirt-engine-remove/config/ca.py Line 72: osetupcons.FileLocations.OVIRT_ENGINE_SERVICE_CONFIG_PKI Line 73: ) Line 74: ) Line 75: ) Line 76: shutil.copytree( please make sure that permissions are kept... If not, please consider to use tar for backup (python tar), and make sure result is owned by root, readable by root. Line 77: osetupcons.FileLocations.OVIRT_ENGINE_PKIDIR, Line 78: os.path.join( Line 79: self._bkpdir, Line 80: os.path.basename(osetupcons.FileLocations.OVIRT_ENGINE_PKIDIR) .................................................... File packaging/setup/plugins/ovirt-engine-remove/files/simple.py Line 159: uninstall_section = ( Line 160: osetupcons.Const.FILE_GROUP_SECTION_PREFIX + Line 161: uninstall_group Line 162: ) Line 163: if config.has_section(uninstall_section): condition should be moved to the previous patch? Line 164: #section could be missing in a conf file, for example if Line 165: #PKI config was not done because already existing Line 166: self._files.update( Line 167: getFiles(uninstall_section) -- To view, visit http://gerrit.ovirt.org/14732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6efe201ed5a9dee7f681ffd61c8f988d24a33a7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
