Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: allow interactive PKI cleanup ......................................................................
Patch Set 6: (2 inline comments) Minor comments. Thanks! .................................................... File packaging/setup/plugins/ovirt-engine-remove/config/ca.py Line 70: Line 71: with tarfile.open(self._bkpfile, 'w:gz') as f: Line 72: f.add(osetupcons.FileLocations.OVIRT_ENGINE_SERVICE_CONFIG_PKI) Line 73: f.add(osetupcons.FileLocations.OVIRT_ENGINE_PKIDIR) Line 74: os.chmod(self._bkpfile, 0o400) not sure ro is good... not critical... Line 75: os.chown( Line 76: self._bkpfile, Line 77: osetuputil.getUid( Line 78: self.environment[osetupcons.SystemEnv.USER_ROOT] .................................................... File packaging/setup/plugins/ovirt-engine-setup/pki/ca.py Line 133: ].createGroup( Line 134: group='ca_pki', Line 135: description='PKI configuration and keys', Line 136: optional=True Line 137: ) .addFiles() Line 138: self.environment[ Line 139: osetupcons.CoreEnv.REGISTER_UNINSTALL_GROUPS Line 140: ].addFiles( Line 141: group='ca_pki', -- To view, visit http://gerrit.ovirt.org/14732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6efe201ed5a9dee7f681ffd61c8f988d24a33a7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
