Daniel Erez has posted comments on this change.
Change subject: frontend: refactor MoveOrCopyDisk and DisksAllocation
......................................................................
Patch Set 2: (8 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 419: @Ignore
Line 420: Label disksAllocationLabel;
Line 421:
Line 422: @UiField(provided = true)
Line 423: @WithElementId
the explicit name is still needed for identifying it on Selenium tests
(probably should run them before merging it...)
Line 424: public DisksAllocationView disksAllocation;
Line 425:
Line 426: // ==Boot Options Tab==
Line 427: @UiField
Line 420: Label disksAllocationLabel;
Line 421:
Line 422: @UiField(provided = true)
Line 423: @WithElementId
Line 424: public DisksAllocationView disksAllocation;
maybe call it 'disksAllocationEditor' instead?
Line 425:
Line 426: // ==Boot Options Tab==
Line 427: @UiField
Line 428: protected DialogTab bootOptionsTab;
Line 937
Line 938
Line 939
Line 940
Line 941
isn't setValue required instead?
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.java
Line 54: @WithElementId("cluster")
Line 55: ListModelListBoxEditor<Object> clusterEditor;
Line 56:
Line 57: @UiField(provided = true)
Line 58: @WithElementId
same
Line 59: DisksAllocationView disksAllocation;
Line 60:
Line 61: @UiField(provided = true)
Line 62: @Path(value = "quota.selectedItem")
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java
Line 36: public class DisksAllocationView extends Composite implements
IsEditor<TakesValueEditor<DisksAllocationModel>>,
Line 37: TakesValue<DisksAllocationModel>, HasElementId,
FocusableComponentsContainer {
Line 38:
Line 39: @Override
Line 40: public TakesValueEditor<DisksAllocationModel> asEditor() {
why TakesValue is better than Editor/Driver (we might want to add editor to it
later on)
Line 41: return TakesValueEditor.of(this);
Line 42: }
Line 43:
Line 44: interface ViewUiBinder extends UiBinder<Widget,
DisksAllocationView> {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
Line 121: if (getQuotaEnforcementType() ==
QuotaEnforcementTypeEnum.DISABLED || storageDomainId == null) {
Line 122: return;
Line 123: }
Line 124:
Line 125: INewAsyncCallback callback = new INewAsyncCallback() {
for even better readability - maybe we can extract it to AsyncDataProvider...
Line 126: @Override
Line 127: public void onSuccess(Object innerModel, Object
innerReturnValue) {
Line 128: @SuppressWarnings("unchecked")
Line 129: ArrayList<Quota> list =
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java
Line 48: }
Line 49:
Line 50: protected DisksAllocationModel disksAllocation;
Line 51:
Line 52: public DisksAllocationModel getDisksAllocation()
actually, the 'Model' post-fix is not that rare (e.g.
SearchableDetailTabModelProvider -> getMainModel(), getCommonModel ->
getCommonModel(),
EntityModelCellTable -> getSelectionModel(), etc.)
Line 53: {
Line 54: return disksAllocation;
Line 55: }
Line 56:
Line 376:
Line 377: parameters.add(params);
Line 378: }
Line 379:
Line 380: public void setWarningAvailable(boolean isWarningAvailable)
* where is it used?
* formatting...
Line 381: {
Line 382: disksAllocation.setWarningAvailable(isWarningAvailable);
Line 383: }
Line 384:
--
To view, visit http://gerrit.ovirt.org/14902
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9757a9bc0b6e9efbd1ab712810d419ab50e01a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
