Daniel Erez has posted comments on this change.
Change subject: frontend: refactor MoveOrCopyDisk and DisksAllocation
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java
Line 36: public class DisksAllocationView extends Composite implements
IsEditor<TakesValueEditor<DisksAllocationModel>>,
Line 37: TakesValue<DisksAllocationModel>, HasElementId,
FocusableComponentsContainer {
Line 38:
Line 39: @Override
Line 40: public TakesValueEditor<DisksAllocationModel> asEditor() {
missed?
Line 41: return TakesValueEditor.of(this);
Line 42: }
Line 43:
Line 44: interface ViewUiBinder extends UiBinder<Widget,
DisksAllocationView> {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java
Line 376:
Line 377: parameters.add(params);
Line 378: }
Line 379:
Line 380: public void setWarningAvailable(boolean isWarningAvailable)
missed?
Line 381: {
Line 382: disksAllocation.setWarningAvailable(isWarningAvailable);
Line 383: }
Line 384:
--
To view, visit http://gerrit.ovirt.org/14902
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9757a9bc0b6e9efbd1ab712810d419ab50e01a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
