Maor Lipchuk has posted comments on this change.
Change subject: core: Re-ordering validations at create snapshot command.
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 63: public CreateAllSnapshotsFromVmCommand(T parameters) {
Line 64: super(parameters);
Line 65: parameters.setEntityId(getVmId());
Line 66: setSnapshotName(parameters.getDescription());
Line 67: setStoragePoolId(getVm() != null ? getVm().getStoragePoolId()
: null);
because the test will not run without it, it fetches from the DB in the
constructor phase
Line 68: }
Line 69:
Line 70: @Override
Line 71: public Map<String, String> getJobMessageProperties() {
Line 335: return true;
Line 336: }
Line 337:
Line 338: protected StoragePoolValidator createStoragePoolValidator() {
Line 339: return new StoragePoolValidator(getStoragePool());
It makes the tests more easy to write, I don't think it is that an issue
Line 340: }
Line 341:
Line 342: protected SnapshotsValidator createSnapshotValidator() {
Line 343: return new SnapshotsValidator();
--
To view, visit http://gerrit.ovirt.org/14964
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58bfc73383ce5ca06bf670a8f63b5563da9caa02
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
