Vered Volansky has posted comments on this change.
Change subject: core: Re-ordering validations at create snapshot command.
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java
Line 40: @Mock
Line 41: private VmValidator vmValidator;
Line 42:
Line 43: @Mock
Line 44: private SnapshotsValidator snapshotValidator;
s/snapshotValidator/snapshotsValidator (plural snapshots for more clarity).
petty, i know...
Line 45:
Line 46: @Mock
Line 47: private DiskImagesValidator diskImagesValidator;
Line 48:
Line 247: List<DiskImage> diskList = new ArrayList<>();
Line 248: return diskList;
Line 249: }
Line 250:
Line 251: private static List<DiskImage> getFullDiskList() {
I'd change the name to NonEmpty/Populated instead of Full. Full is misleading.
Line 252: List<DiskImage> diskList = new ArrayList<>();
Line 253: DiskImage newDiskImage = new DiskImage();
Line 254: diskList.add(newDiskImage);
Line 255: return diskList;
--
To view, visit http://gerrit.ovirt.org/14964
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58bfc73383ce5ca06bf670a8f63b5563da9caa02
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
