Gilad Chaplik has posted comments on this change.
Change subject: engine: rename quota limit labels
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 605: @DefaultStringValue("CPU Threads")
Line 606: String clusterPopupCpuThreadsPanelTitle();
Line 607:
Line 608: @DefaultStringValue("Allow guests to use host threads as virtual
CPU cores, utilizing AMD Clustered MultiThreading or Intel"
Line 609: +
10x for noticing, will fix it on rebase
Line 610: " Hyper-Threading technology on the virtualization host.
Enabling this option may be useful for less" +
Line 611: " CPU-intensive workloads, or to run guests with CPU
configurations that would otherwise be restricted.")
Line 612: String clusterPopupCpuThreadsInfo();
Line 613:
Line 2502: String quotaStorageThreshold();
Line 2503:
Line 2504: @DefaultStringValue("Storage Hard Limit")
Line 2505: String quotaStorageGrace();
Line 2506:
ammm, I thought about it when I writing the patch.
this will cause some overhead for localization, what do you say?
Line 2507: @DefaultStringValue("Clone All VMs")
Line 2508: String importVm_cloneAllVMs();
Line 2509:
Line 2510: @DefaultStringValue("Clone All Templates")
--
To view, visit http://gerrit.ovirt.org/14168
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I889f019b18b23c3b666d4d8e14a614103123fc30
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
