Tomas Jelinek has posted comments on this change.
Change subject: engine: rename quota limit labels
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 2502: String quotaStorageThreshold();
Line 2503:
Line 2504: @DefaultStringValue("Storage Hard Limit")
Line 2505: String quotaStorageGrace();
Line 2506:
well, I would vote for renaming it but will not block this patch on this.
Giving +1 and let it to your consideration.
Line 2507: @DefaultStringValue("Clone All VMs")
Line 2508: String importVm_cloneAllVMs();
Line 2509:
Line 2510: @DefaultStringValue("Clone All Templates")
--
To view, visit http://gerrit.ovirt.org/14168
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I889f019b18b23c3b666d4d8e14a614103123fc30
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
