Maor Lipchuk has uploaded a new change for review. Change subject: core: Remove call to super CDA ......................................................................
core: Remove call to super CDA 1) Remove call to super CDA after it was removed from StoragePoolManagementCommandBase in the previous patch. 2) Moved initialization action type from the CDA to setActionMessageParameters. Change-Id: I33046daed409f8a0d7ad1680191ba7824087402a Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/15088/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java index a80cee2..63571d5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java @@ -65,10 +65,14 @@ } @Override - protected boolean canDoAction() { + protected void setActionMessageParameters() { + super.setActionMessageParameters(); addCanDoActionMessage(VdcBllMessages.VAR__ACTION__CREATE); - boolean result = super.canDoAction(); + } + @Override + protected boolean canDoAction() { + boolean result = true; StoragePoolValidator storagePoolValidator = new StoragePoolValidator(getStoragePool()); if (result && DbFacade.getInstance().getStoragePoolDao().getByName(getStoragePool().getname()) != null) { result = false; -- To view, visit http://gerrit.ovirt.org/15088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33046daed409f8a0d7ad1680191ba7824087402a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
