Vered Volansky has posted comments on this change. Change subject: core: Remove call to super CDA ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java Line 66 Line 67 Line 68 Line 69 Line 70 Inheritance should work like this: If the father does it, assume sons do it too. if you don't want it, go to them and change. Your approach has the same issue, only in reverse. If I add something everybody else needs, I'll go make sure they do use. This is the opposite approach, and not what's intended in inheritance. I get that we often break it and with good reason, but I don't see a reason to do it here. Discussed with Maor offline, BTW. If this get's +2 like this I'm not going to raise hell, but this is still my opinion. -- To view, visit http://gerrit.ovirt.org/15088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33046daed409f8a0d7ad1680191ba7824087402a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
