Kanagaraj M has posted comments on this change.
Change subject: gluster: Add gluster hook to missing servers
......................................................................
Patch Set 1: (3 inline comments)
Error messages changes should be applied to frontend AppErrors as well.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java
Line 49: protected BackendInternal getBackend() {
Line 50: return super.getBackend();
Line 51: }
Line 52:
Line 53: protected GlusterHookEntity getGlusterHook() {
This method can be moved to GlusterHookCommandBase to avoid repeating it in all
the hook related commands
Line 54: if (entity == null) {
Line 55: entity =
getGlusterHooksDao().getById(getParameters().getHookId(),true);
Line 56: }
Line 57: return entity;
Line 143: }
Line 144:
Line 145: if (getSucceeded()) {
Line 146: entity.removeMissingConflict();
Line 147: getGlusterHooksDao().updateGlusterHook(entity);
How about removing the entries from gluster_server_hooks table for the
succeeded servers?
Line 148: }
Line 149:
Line 150: }
Line 151:
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
Line 589:
Line 590: String VdcActionType___DisableGlusterHook();
Line 591:
Line 592: String VdcActionType___UpdateGlusterHook();
Line 593:
Please remove the empty spaces/tabs
Line 594: String VdcActionType___AddGlusterHook();
Line 595:
Line 596: String VdcActionType___ConnectStorageToVds();
Line 597:
--
To view, visit http://gerrit.ovirt.org/15093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a9b47b18e6fffc43393fdcf09f09f714f734b3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
