Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Add gluster hook to missing servers
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java
Line 69:
Line 70: for (GlusterServerHook serverHook: getMissingServerHooks()) {
Line 71: VDS vds = getVdsDAO().get(serverHook.getServerId());
Line 72: if (vds == null || vds.getStatus() != VDSStatus.Up) {
Line 73: setVdsName(vds != null ? vds.getName() : "No Server");
Check if the value needs to be "NO SERVER" in case when vds is null here as
well.
Line 74:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_SERVER_STATUS_NOT_UP);
Line 75: return false;
Line 76: }
Line 77: }
--
To view, visit http://gerrit.ovirt.org/15093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a9b47b18e6fffc43393fdcf09f09f714f734b3d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
