Tomáš Došek has posted comments on this change.
Change subject: engine: Fix for BZ#967890 - enhance logging of JndiAction level
in dEBUG mode
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
Line 112: }
Line 113: userGuid.append(guid);
Line 114: log.debug("User guid is: " +
userGuid.toString());
Line 115: return AuthenticationResult.OK;
Line 116: }
That's not my code actually. It might be worth another patching. However that
would have to be done in another commit (as it's not directly logging and
assigned bug related).
I guess following code should get in another commit:
if (answer.hasMoreElements()) {
String guid = guidFromResults(answer.next());
if (guid != null) {
userGuid.append(guid);
log.debug("User guid is: " + userGuid.toString());
return AuthenticationResult.OK;
}
}
Line 117: // Print user GUID only if it was not printed
previously in while loop
Line 118: if (!answer.hasMoreElements()) {
Line 119: log.debug("User guid is: " +
userGuid.toString());
Line 120: }
Line 116: }
Line 117: // Print user GUID only if it was not printed
previously in while loop
Line 118: if (!answer.hasMoreElements()) {
Line 119: log.debug("User guid is: " +
userGuid.toString());
Line 120: }
If it's true we already print the selected user GUID in the while loop so it's
not necessary to duplicate the log entry.
Line 121: // Print also URI and complete query path
Line 122: log.debug("URI is: " + uri.toString());
Line 123: log.debug("Complete query path is: " +
currentLdapServer);
Line 124: System.out.println("No user in Directory was
found for " + userName
--
To view, visit http://gerrit.ovirt.org/15176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84525767c98eda9eba522dc5518c02c10c55fbfa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomáš Došek <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Tomáš Došek <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
