Martin Peřina has posted comments on this change.
Change subject: engine: Fix for BZ#967890 - enhance logging of JndiAction level
in dEBUG mode
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
Line 112: }
Line 113: userGuid.append(guid);
Line 114: log.debug("User guid is: " +
userGuid.toString());
Line 115: return AuthenticationResult.OK;
Line 116: }
I know it's not part of the patch, but your patch closely depends on it. And
yes, this is much more readable and it also will be much more readable after
you insert your patch in correct place.
Line 117: // Print user GUID only if it was not printed
previously in while loop
Line 118: if (!answer.hasMoreElements()) {
Line 119: log.debug("User guid is: " +
userGuid.toString());
Line 120: }
Line 116: }
Line 117: // Print user GUID only if it was not printed
previously in while loop
Line 118: if (!answer.hasMoreElements()) {
Line 119: log.debug("User guid is: " +
userGuid.toString());
Line 120: }
Not true, look at following example (but I'm not sure if it can happen on real
data):
1) Suppose you will get 2 items in your example: from the 1st one you will get
null guid and exits loop without touching the 2nd one.
2) You exited the loop, but since there are 2 items in answer, you will not
log userGuid
Line 121: // Print also URI and complete query path
Line 122: log.debug("URI is: " + uri.toString());
Line 123: log.debug("Complete query path is: " +
currentLdapServer);
Line 124: System.out.println("No user in Directory was
found for " + userName
--
To view, visit http://gerrit.ovirt.org/15176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84525767c98eda9eba522dc5518c02c10c55fbfa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomáš Došek <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Tomáš Došek <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
