Liron Ar has posted comments on this change.

Change subject: core: RegisterDiskCommand - correct storage domain
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java
Line 57:         
newDiskImage.setDiskAlias(ImagesHandler.getDiskAliasWithDefault(newDiskImage,
Line 58:                 
generateDefaultAliasForRegiteredDisk(Calendar.getInstance())));
Line 59:         ArrayList<Guid> storageIds = new ArrayList<>();
Line 60:         storageIds.add(getParameters().getStorageDomainId());
Line 61:         newDiskImage.setStorageIds(storageIds);
because it's an arraylist (GWT)
Line 62:         addDiskImageToDb(newDiskImage, getCompensationContext());
Line 63:         getReturnValue().setActionReturnValue(newDiskImage.getId());
Line 64:         getReturnValue().setSucceeded(true);
Line 65:     }


--
To view, visit http://gerrit.ovirt.org/15193
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I568668fc1a8024ff255754287afbaa5d35b8a2ed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to