Maor Lipchuk has posted comments on this change. Change subject: core: RegisterDiskCommand - correct storage domain ......................................................................
Patch Set 2: Looks good to me, approved (1 inline comment) .................................................... Commit Message Line 6: Line 7: core: RegisterDiskCommand - correct storage domain Line 8: Line 9: When registering new disk, the disk was saved to the db using the domain Line 10: information stored on it's metadata - this can cause to failure during /s/it's/its Line 11: registration or to have incorrect information stored in the engine db. Line 12: The domain on which the disk was existed on isn't necessarily the Line 13: new one on which the disk is now, so it shouldn't be saved with it. Line 14: -- To view, visit http://gerrit.ovirt.org/15193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I568668fc1a8024ff255754287afbaa5d35b8a2ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Chris Morrissey <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
